Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pid 1 problem #493

Merged
merged 1 commit into from
Nov 6, 2018
Merged

fix pid 1 problem #493

merged 1 commit into from
Nov 6, 2018

Conversation

lvjing2
Copy link
Contributor

@lvjing2 lvjing2 commented Nov 5, 2018

Fixes #(issue-number)
Fix the problem 1 in knative/serving#2388

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 5, 2018
@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 5, 2018
@lvjing2
Copy link
Contributor Author

lvjing2 commented Nov 5, 2018

It's wired I can't sign the cla here because I had already signed the cla in knative/serving,

@lvjing2
Copy link
Contributor Author

lvjing2 commented Nov 5, 2018

I signed it!

Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

We need a better Dockerfile for this sample, but thanks for the change.

@lvjing2
Copy link
Contributor Author

lvjing2 commented Nov 5, 2018

@mattmoor I can't pass the cla check, so just leave it as a reminder to optimize the dockerfile, and close this pr after it had been improved.

@mattmoor
Copy link
Member

mattmoor commented Nov 5, 2018

@lvjing2 perhaps change the commit author locally and git commit --amend?

/ok-to-test

@knative-prow-robot knative-prow-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 5, 2018
@googlebot
Copy link

CLAs look good, thanks!

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lvjing2, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants